[react-events] Remove lastNativeEvent in favor of EventSystemFlags #17585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7f490b1:
|
c58239e to
7f490b1
Compare
sebmarkbage
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #17582.
Notably, this removes the usage of storing the
lastNativeEventin a binding in the EnterLeavePlugin module – which can leak memory. Instead, we utilize the EventSystemFlags system which was recently exposed to EventPlugins by @sebmarkbage's work on the event replay system.We mark when the EventPlugin is handling the first ancestor on the flags directly, meaning we don't need to monkey patch the native events or use WeakSets/Sets to achieve the goal – removing the use case of
lastNativeEvent.