Cleanup Babel PR (ReactFreshPlugin) #16340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…react into fixed_react_fresh_test
gaearon
approved these changes
Aug 9, 2019
|
No significant bundle size changes to report. Generated by 🚫 dangerJS |
acdlite
reviewed
Aug 9, 2019
| @@ -11,7 +11,7 @@ export default function(babel) { | |||
| if (typeof babel.getEnv === 'function') { | |||
| // Only available in Babel 7. | |||
| const env = babel.getEnv(); | |||
| if (env !== 'development') { | |||
| if (env !== 'development' && typeof expect !== 'function') { | |||
There was a problem hiding this comment.
@gaearon My understanding was that one of the purposes of this error is to prevent people from enabling the Fresh plugin when compiling their unit tests. Doesn't this change mean that consumers of this plugin who use Jest won't get the error below?
There was a problem hiding this comment.
We actually do run it in tests in fbsource. So I don't know that it's necessarily a bad idea.
The primary purpose is to prevent people from including it in prod setups.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the comments in #16297
In particular, for
ReactFreshBabelPlugin, @gaearon mentioned that we could modify theReactFreshBabelPluginto not throw an error if it is run in a test (ifexpectis a function it is most likely in a test environment) instead of setting a precedent for modifying the jest config.