Skip to content

Ensure Fundamental flags are added to more locations #16311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2019
Merged

Ensure Fundamental flags are added to more locations #16311

merged 1 commit into from
Aug 7, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Aug 7, 2019

This wraps the fundamental build flag around more call-sites that were missed from when the code was merged. I scanned through the UMD prod build and confirmed that no more locations existed too.

@sizebot
Copy link

sizebot commented Aug 7, 2019

Details of bundled changes.

Comparing: c4f0b93...78b6d3f

react-dom

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-dom.profiling.min.js -0.2% 0.0% 115.09 KB 114.87 KB 36.24 KB 36.25 KB NODE_PROFILING
ReactDOM-dev.js 0.0% 0.0% 934 KB 934.09 KB 206.42 KB 206.42 KB FB_WWW_DEV
react-dom-test-utils.development.js +4.3% +6.8% 55.72 KB 58.12 KB 14.95 KB 15.96 KB UMD_DEV
react-dom-unstable-fizz.browser.development.js 0.0% -0.1% 3.78 KB 3.78 KB 1.52 KB 1.52 KB UMD_DEV
react-dom-test-utils.development.js +4.4% +6.9% 53.99 KB 56.39 KB 14.62 KB 15.62 KB NODE_DEV
react-dom-test-utils.production.min.js 0.0% 0.0% 11.1 KB 11.1 KB 4.13 KB 4.13 KB NODE_PROD
react-dom.development.js 0.0% 0.0% 909.97 KB 910.07 KB 206.29 KB 206.3 KB UMD_DEV
react-dom.production.min.js -0.2% -0.1% 111.47 KB 111.25 KB 35.86 KB 35.84 KB UMD_PROD
ReactTestUtils-dev.js +1.9% +2.0% 52.66 KB 53.65 KB 14.01 KB 14.29 KB FB_WWW_DEV
react-dom.profiling.min.js -0.2% 0.0% 114.88 KB 114.66 KB 36.88 KB 36.9 KB UMD_PROFILING
react-dom.development.js 0.0% 0.0% 904.27 KB 904.37 KB 204.7 KB 204.71 KB NODE_DEV
react-dom.production.min.js -0.2% 0.0% 111.45 KB 111.22 KB 35.29 KB 35.29 KB NODE_PROD
react-dom-server.node.production.min.js 0.0% 0.0% 20.17 KB 20.17 KB 7.57 KB 7.57 KB NODE_PROD
ReactDOM-prod.js -0.1% -0.0% 372.98 KB 372.79 KB 68.47 KB 68.45 KB FB_WWW_PROD
ReactDOM-profiling.js -0.1% -0.0% 377.5 KB 377.31 KB 69.5 KB 69.46 KB FB_WWW_PROFILING
react-dom-server.browser.development.js 0.0% -0.0% 134.64 KB 134.64 KB 35.5 KB 35.5 KB NODE_DEV
react-dom-server.browser.production.min.js 0.0% 0.0% 19.32 KB 19.32 KB 7.26 KB 7.27 KB NODE_PROD
react-dom-unstable-native-dependencies.production.min.js 0.0% 0.0% 10.74 KB 10.74 KB 3.68 KB 3.68 KB UMD_PROD

react-reconciler

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-reconciler.development.js 0.0% 0.0% 576.21 KB 576.3 KB 122.38 KB 122.41 KB NODE_DEV
react-reconciler.production.min.js -0.2% -0.2% 68.66 KB 68.52 KB 20.42 KB 20.37 KB NODE_PROD
react-reconciler-reflection.development.js +14.8% +20.6% 16.63 KB 19.09 KB 5.16 KB 6.22 KB NODE_DEV
react-reconciler-reflection.production.min.js -0.5% -0.6% 2.59 KB 2.58 KB 1.14 KB 1.13 KB NODE_PROD
react-reconciler-persistent.development.js 0.0% -0.0% 573.21 KB 573.31 KB 121.12 KB 121.11 KB NODE_DEV
react-reconciler-persistent.production.min.js -0.2% -0.2% 68.67 KB 68.53 KB 20.42 KB 20.38 KB NODE_PROD

Generated by 🚫 dangerJS

@trueadm trueadm merged commit 028c07f into facebook:master Aug 7, 2019
@trueadm trueadm deleted the add-missing-fund-flags branch August 7, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaearon gaearon gaearon approved these changes

@threepointone threepointone Awaiting requested review from threepointone

@sebmarkbage sebmarkbage Awaiting requested review from sebmarkbage

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueadm @sizebot @gaearon @facebook-github-bot