Skip to content

[Flare] Remove delay props from Hover #16248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2019
Merged

[Flare] Remove delay props from Hover #16248

merged 1 commit into from
Jul 30, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Jul 30, 2019

Moving working with delays into user-space.

@necolas
[Flare] Remove delay props from Hover
7eccd51 
Moving working with delays into user-space.
@necolas necolas requested a review from trueadm July 30, 2019 01:27
@sizebot
Copy link

sizebot commented Jul 30, 2019

Details of bundled changes.

Comparing: 144dba1...7eccd51

react-events

File Filesize Diff Gzip Diff Prev Size Current Size Prev Gzip Current Gzip ENV
react-events-focus-scope.development.js 0.0% +0.1% 4.47 KB 4.47 KB 1.31 KB 1.31 KB UMD_DEV
react-events-scroll.development.js 0.0% +0.1% 5.57 KB 5.57 KB 1.53 KB 1.53 KB UMD_DEV
react-events-focus-scope.production.min.js 0.0% 🔺+0.2% 1.73 KB 1.73 KB 887 B 889 B UMD_PROD
react-events-scroll.production.min.js 0.0% 🔺+0.1% 2.3 KB 2.3 KB 1.06 KB 1.06 KB UMD_PROD
react-events-hover.development.js -14.2% -15.2% 7.42 KB 6.37 KB 1.91 KB 1.62 KB UMD_DEV
react-events-drag.development.js 0.0% +0.1% 5.32 KB 5.32 KB 1.58 KB 1.58 KB UMD_DEV
react-events-hover.production.min.js -13.4% -10.6% 3.38 KB 2.92 KB 1.28 KB 1.15 KB UMD_PROD
react-events-drag.production.min.js 0.0% 🔺+0.2% 2.38 KB 2.38 KB 1.1 KB 1.1 KB UMD_PROD
react-events-hover.development.js -14.6% -15.6% 7.24 KB 6.19 KB 1.86 KB 1.57 KB NODE_DEV
react-events-drag.development.js 0.0% 0.0% 7.08 KB 7.08 KB 2.24 KB 2.24 KB NODE_DEV
react-events-hover.production.min.js -14.2% -11.8% 3.2 KB 2.74 KB 1.22 KB 1.08 KB NODE_PROD
react-events-drag.production.min.js 0.0% 🔺+0.1% 3.02 KB 3.02 KB 1.41 KB 1.41 KB NODE_PROD
react-events-press.development.js 0.0% 0.0% 24.97 KB 24.97 KB 5.68 KB 5.68 KB UMD_DEV
react-events-swipe.development.js 0.0% +0.1% 6.17 KB 6.17 KB 1.69 KB 1.7 KB UMD_DEV
react-events-press.production.min.js 0.0% 0.0% 8.63 KB 8.63 KB 3.06 KB 3.06 KB UMD_PROD
ReactEventsHover-dev.js -15.1% -15.9% 7.32 KB 6.22 KB 1.88 KB 1.58 KB FB_WWW_DEV
react-events-swipe.production.min.js 0.0% 🔺+0.2% 2.57 KB 2.57 KB 1.17 KB 1.18 KB UMD_PROD
ReactEventsHover-prod.js -11.6% -11.5% 5.98 KB 5.28 KB 1.58 KB 1.4 KB FB_WWW_PROD
react-events-press.development.js 0.0% 0.0% 24.79 KB 24.79 KB 5.62 KB 5.63 KB NODE_DEV
react-events-swipe.development.js 0.0% +0.1% 5.99 KB 5.99 KB 1.65 KB 1.65 KB NODE_DEV
react-events-press.production.min.js 0.0% 0.0% 8.44 KB 8.44 KB 3 KB 3.01 KB NODE_PROD
react-events-swipe.production.min.js 0.0% 🔺+0.2% 2.39 KB 2.39 KB 1.12 KB 1.12 KB NODE_PROD
react-events-focus-scope.development.js 0.0% +0.2% 4.28 KB 4.28 KB 1.26 KB 1.26 KB NODE_DEV
react-events-scroll.development.js 0.0% +0.1% 5.38 KB 5.38 KB 1.47 KB 1.47 KB NODE_DEV
react-events-focus-scope.production.min.js 0.0% 🔺+0.2% 1.55 KB 1.55 KB 814 B 816 B NODE_PROD
react-events-scroll.production.min.js 0.0% 🔺+0.1% 2.11 KB 2.11 KB 1000 B 1001 B NODE_PROD
react-events-focus.development.js 0.0% +0.1% 9.45 KB 9.45 KB 2.01 KB 2.01 KB UMD_DEV
react-events-input.development.js 0.0% +0.1% 4.31 KB 4.31 KB 1.38 KB 1.38 KB UMD_DEV
react-events-focus.production.min.js 0.0% 🔺+0.2% 3.71 KB 3.71 KB 1.24 KB 1.24 KB UMD_PROD
react-events-input.production.min.js 0.0% 🔺+0.2% 1.75 KB 1.75 KB 951 B 953 B UMD_PROD
react-events-focus.development.js 0.0% +0.1% 9.26 KB 9.26 KB 1.96 KB 1.96 KB NODE_DEV
react-events-input.development.js 0.0% +0.1% 4.13 KB 4.13 KB 1.33 KB 1.33 KB NODE_DEV
react-events-focus.production.min.js 0.0% 🔺+0.1% 3.53 KB 3.53 KB 1.17 KB 1.17 KB NODE_PROD
react-events-input.production.min.js 0.0% 🔺+0.2% 1.58 KB 1.58 KB 882 B 884 B NODE_PROD

Generated by 🚫 dangerJS

@necolas necolas merged commit e276a5e into facebook:master Jul 30, 2019
@necolas necolas deleted the react-events/remove-hover-delays branch December 20, 2019 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@trueadm trueadm trueadm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@necolas @sizebot @trueadm @facebook-github-bot