Skip to content

[ESLint] Validate useEffect without deps too #15183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2019
Merged

[ESLint] Validate useEffect without deps too #15183

merged 1 commit into from
Mar 21, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 21, 2019

There's a few checks that are still useful whether you specified deps or not. We used to exit too early, but not we exit until we actually need declared deps. This will catch more mistakes.

@gaearon gaearon requested a review from bvaughn March 21, 2019 19:57
@gaearon gaearon merged commit 78968bb into facebook:master Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bvaughn bvaughn bvaughn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @bvaughn @facebook-github-bot