Skip to content

Test that we don't suspend when disabling yielding #15143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2019
Merged

Test that we don't suspend when disabling yielding #15143

merged 1 commit into from
Mar 18, 2019

Conversation

sebmarkbage
Copy link
Collaborator

Just adding a test to confirm this works.

@sebmarkbage sebmarkbage requested a review from acdlite March 18, 2019 21:27
@acdlite
Copy link
Collaborator

acdlite commented Mar 18, 2019

Thanks for adding this because I think this behavior is an implementation accident — it's the desired behavior, but I when I implemented this I didn't consider the case where we don't yield but the work hasn't expired.

@sebmarkbage sebmarkbage merged commit 1e3364e into facebook:master Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acdlite acdlite acdlite approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sebmarkbage @acdlite @facebook-github-bot