Skip to content

Change passive checker to use defineProperty #15121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 15, 2019
Merged

Change passive checker to use defineProperty #15121

merged 1 commit into from
Mar 15, 2019

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Mar 15, 2019

This converts the passive check to use defineProperty so that this works in older browsers that do not support newer syntax.

@trueadm trueadm requested review from sebmarkbage and gaearon March 15, 2019 22:13
gaearon
gaearon approved these changes Mar 15, 2019
View reviewed changes
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls verify this doesn't accidentally break feature test somehow

@trueadm
Copy link
Contributor Author

trueadm commented Mar 15, 2019

Validated it still works as intended.

@trueadm trueadm merged commit 035e4cf into facebook:master Mar 15, 2019
@trueadm trueadm deleted the use-definte-property branch March 15, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebmarkbage sebmarkbage sebmarkbage approved these changes

@gaearon gaearon gaearon approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trueadm @sebmarkbage @gaearon @facebook-github-bot