Skip to content

Improve async useEffect warning #15104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

Improve async useEffect warning #15104

merged 1 commit into from
Mar 13, 2019

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Mar 13, 2019

  1. Move the function inside an effect to reduce the confusion about deps (Add more info to FAQ about deps reactjs/react.dev#1815).
  2. Tweak capitalization (doesn't really matter but we don't capitalize effects in docs).
  3. Add a link which goes into our FAQ and itself links to a CodeSandbox demo and an article. This will unblock people who are confused about data fetching.

@gaearon gaearon requested a review from threepointone March 13, 2019 16:05
@gaearon gaearon merged commit 9d77a31 into facebook:master Mar 13, 2019
gaearon added a commit to gaearon/react that referenced this pull request Mar 22, 2019
@gaearon
Improve async useEffect warning (facebook#15104)
13a3788
@gaearon gaearon mentioned this pull request Mar 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@threepointone threepointone threepointone approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaearon @threepointone @facebook-github-bot