Skip to content

React Events: FocusScope tweaks and docs #15515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2019
Merged

React Events: FocusScope tweaks and docs #15515

merged 2 commits into from
Apr 26, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Apr 26, 2019

  • FocusScope: rename trap to contain.
  • FocusScope: avoid potential for el.focus() errors.
  • FocusScope: add docs,
  • Update docs formatting,

@necolas necolas requested a review from trueadm April 26, 2019 19:57
trueadm
trueadm approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@necolas necolas merged commit cc5a493 into facebook:master Apr 26, 2019
@necolas necolas deleted the react-events/focus-scope-and-docs branch May 3, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@trueadm trueadm trueadm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@necolas @trueadm @facebook-github-bot