Skip to content

React events: use passive events where possible #15454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 19, 2019
Merged

React events: use passive events where possible #15454

merged 1 commit into from
Apr 19, 2019

Conversation

necolas
Copy link
Contributor

@necolas necolas commented Apr 19, 2019

We can use passive events for these root event types as we're never calling preventDefault on the native events.

@necolas necolas requested a review from trueadm April 19, 2019 18:03
@necolas necolas force-pushed the react-events/more-passive-events branch from 67d76bd to d0c0113 Compare April 19, 2019 18:16
@necolas necolas merged commit d584fcd into facebook:master Apr 19, 2019
@necolas necolas deleted the react-events/more-passive-events branch May 3, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@trueadm trueadm trueadm approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@necolas @trueadm @facebook-github-bot