Add failing test for stuck Suspense fallback #14079
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be the same problem as #14013? Don't know. |
Details of bundled changes.Comparing: c84b9bf...06433bb scheduler
Generated by 🚫 dangerJS |
|
What is supposed to set .alreadyCaptured to false? It seems like once it gets set to true, the only thing that can set it back to false (and thus trigger a retry of the primary content) is the commit phase, which never runs for a suspended update. Not sure if I'm missing some part of the model in my head. cc @acdlite |
Looks like it. Seems like once something pings once in concurrent mode, further pings end up being no-ops. |
|
Fixed by #14083 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another issue that was discovered in #14073 (comment) (although this one is specific to concurrent mode). This just looks like a bug.
Setting second child's
mslower does not reproduce it.