Skip to content

Conversation

nhunzaker
Copy link
Contributor

Resubmitting @guuibayer's license updates from a non-master branch. It's out of date and I didn't get a response, but I think the licences should be updated.

Copy link
Contributor

@threepointone threepointone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! I assume every other file have this already?

@nhunzaker
Copy link
Contributor Author

@threepointone Caught two more places in the source. I also noticed that builds are generating the old license, but I can't figure out where that's coming from.

@nhunzaker
Copy link
Contributor Author

Got it. This is coming through the prop-types package:
https://github.com/facebook/prop-types/blob/master/index.js#L2

Want me to update it there as well?

@nhunzaker nhunzaker merged commit d0318fb into facebook:master Feb 21, 2019
@threepointone
Copy link
Contributor

yeah we should update it there too, but there's no hurry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants