ReactDOM.createRoot #11225
Merged
ReactDOM.createRoot #11225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce new API for creating roots. Only root.render and root.unmount are implemented. Later we'll add root.prerender, and support for lazy roots (roots with DOM containers that resolve lazily).
eef374b to
3d91f47
Compare
sebmarkbage
approved these changes
Oct 14, 2017
sebmarkbage
reviewed
Oct 14, 2017
| ReactRoot.prototype.unmount = function(callback) { | ||
| const root = this._reactRootContainer; | ||
| DOMRenderer.updateContainer(null, root, null, callback); | ||
| }; |
There was a problem hiding this comment.
So this is not a destroy method now? It's possible to render again after an unmount. With deterministic updates, is the motivation for the new API as strong?
There was a problem hiding this comment.
Nah, should probably throw? I'll address in a follow-up.
12 tasks
This was referenced Aug 7, 2020
This was referenced Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new API for creating roots. Only
root.renderandroot.unmountare implemented. Later we'll addroot.prerender, and support for lazy roots (roots with DOM containers that resolve lazily).