-
Notifications
You must be signed in to change notification settings - Fork 49.2k
Comparing changes
Open a pull request
base repository: facebook/react
base: 740a4f7a
head repository: facebook/react
compare: 313332d1
- 6 commits
- 23 files changed
- 3 contributors
Commits on Mar 25, 2025
-
[ci] Fix incorrect condition (#32746)
Oops, missed this when I switched it from checking if its a fork to checking if its from this repo.
Configuration menu - View commit details
-
Copy full SHA for 553a175 - Browse repository at this point
Copy the full SHA 553a175View commit details -
[ci] Fix param casing (#32748)
Casing was incorrect. Tested by running locally with a PAT. ``` $ scripts/release/download-experimental-build.js --commit=2d40460cf768071d3a70b4cdc16075d23ca1ff25 Command failed: gh attestation verify artifacts_combined.zip --repo=facebook/react Error: failed to fetch attestations from facebook/react: HTTP 404: Not Found (https://api.github.com/repos/facebook/react/attestations/sha256:23d05644f9e49e02cbb441e3932cc4366b261826e58ce222ea249a6b786f0b5f?per_page=30) `gh attestation verify artifacts_combined.zip --repo=facebook/react` (exited with error code 1) $ scripts/release/download-experimental-build.js --commit=2d40460cf768071d3a70b4cdc16075d23ca1ff25 --noVerify ⠼ Downloading artifacts from GitHub for commit 2d40460) 5% 0.1m, estimated 1.6m ✓ Downloading artifacts from GitHub for commit 2d40460) 9.5 secs An experimental build has been downloaded! You can download this build again by running: scripts/download-experimental-build.js --commit=2d40460cf768071d3a70b4cdc16075d23ca1ff25 ```
Configuration menu - View commit details
-
Copy full SHA for 4845e16 - Browse repository at this point
Copy the full SHA 4845e16View commit details
Commits on Mar 26, 2025
-
Avoid double logging component render time (#32749)
This got moved into the functional component and class component case statements here: 0de1233. So that we could separate the error case for class components. However, due to a faulty rebase this got restored at the top as well. Leading to double component renders being logged. In the other offscreen reconnect passes we don't do this in each case statement but still once at the top. The reason this doesn't matter is because use the PerformedWork flag and that is only set for function and class components. Although maybe it should be set for expensive DOM components too and then we have to remember this.
Configuration menu - View commit details
-
Copy full SHA for f9e1b16 - Browse repository at this point
Copy the full SHA f9e1b16View commit details -
Warn for duplicate ViewTransition names (#32752)
This adds early logging when two ViewTransitions with the same name are mounted at the same time. Whether they're part of a View Transition or not. This lets us include the owner stack of each one. I do two logs so that you can get the stack trace of each one of the duplicates. It currently only logs once for each name which also avoids the scenario when you have many hits for the same name in one commit. However, we could also possibly log a stack for each of them but seems noisy. Currently we don't log if a SwipeTransition is the first time the pair gets mounted which could lead to a View Transition error before we've warned. That could be a separate improvement.
Configuration menu - View commit details
-
Copy full SHA for 8ac25e5 - Browse repository at this point
Copy the full SHA 8ac25e5View commit details -
Fix ownerStackLimit feature gating for tests (#32726)
#32529 added a dynamic flag for this, but that breaks tests since the flags are not defined everywhere. However, this is a static value and the flag is only for supporting existing tests. So we can override it in the test config, and make it static at built time instead.
Configuration menu - View commit details
-
Copy full SHA for f99c9fe - Browse repository at this point
Copy the full SHA f99c9feView commit details -
[crud] Revert CRUD overload (#32741)
Cleans up this experiment. After some internal experimentation we are deprioritizing this project for now and may revisit it at a later point.
Configuration menu - View commit details
-
Copy full SHA for 313332d - Browse repository at this point
Copy the full SHA 313332dView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 740a4f7a...313332d1