Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: facebook/react
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 7283a213
Choose a base ref
...
head repository: facebook/react
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 65e06cb7
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Dec 19, 2024

  1. [Flight Reply] Reject any new Chunks not yet discovered at the time o… 

    …f reportGlobalError (#31840)

We might have already resolved models that are not pending and so are
not rejected by aborting the stream. When those later get parsed they
might discover new chunks which end up as pending. These should be
errored since they will never be able to resolve later.

This avoids infinitely hanging the stream.

This same fix needs to be ported to ReactFlightClient that has the same
issue.
    @sebmarkbage @gnoff
    sebmarkbage authored and gnoff committed Dec 19, 2024
    Configuration menu
    Copy the full SHA
    4af4031 View commit details
    Browse the repository at this point in the history

  2. Merge 4af4031 into 7283a21

    @gnoff
    gnoff authored Dec 19, 2024
    Configuration menu
    Copy the full SHA
    65e06cb View commit details
    Browse the repository at this point in the history
Loading