Fix warning message for new setNativeProps method. on -> with (#14909)

elicwhite · web-flow · commit f978d5fde422 · 2019-02-20T23:53:21.000-08:00
diff --git a/packages/react-native-renderer/src/ReactNativeRendererSharedExports.js b/packages/react-native-renderer/src/ReactNativeRendererSharedExports.js
@@ -19,7 +19,7 @@ export function setNativeProps(handle: any, nativeProps: Object): void {
   if (handle._nativeTag == null) {
     warningWithoutStack(
       handle._nativeTag != null,
-      "setNativeProps was called on a ref that isn't a " +
+      "setNativeProps was called with a ref that isn't a " +
         'native component. Use React.forwardRef to get access to the underlying native component',
     );
     return;
diff --git a/packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js b/packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js
@@ -287,7 +287,7 @@ describe('ReactFabric', () => {
         ReactFabric.setNativeProps(viewRef, {foo: 'baz'});
       }).toWarnDev(
         [
-          "Warning: setNativeProps was called on a ref that isn't a " +
+          "Warning: setNativeProps was called with a ref that isn't a " +
             'native component. Use React.forwardRef to get access ' +
             'to the underlying native component',
         ],
diff --git a/packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js b/packages/react-native-renderer/src/__tests__/ReactNativeMount-test.internal.js
@@ -218,7 +218,7 @@ describe('ReactNative', () => {
         ReactNative.setNativeProps(viewRef, {foo: 'baz'});
       }).toWarnDev(
         [
-          "Warning: setNativeProps was called on a ref that isn't a " +
+          "Warning: setNativeProps was called with a ref that isn't a " +
             'native component. Use React.forwardRef to get access ' +
             'to the underlying native component',
         ],

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ describe('ReactFabric', () => {`
`287`	`287`	`ReactFabric.setNativeProps(viewRef, {foo: 'baz'});`
`288`	`288`	`}).toWarnDev(`
`289`	`289`	`[`
`290`		`- "Warning: setNativeProps was called on a ref that isn't a " +`
	`290`	`+ "Warning: setNativeProps was called with a ref that isn't a " +`
`291`	`291`	`'native component. Use React.forwardRef to get access ' +`
`292`	`292`	`'to the underlying native component',`
`293`	`293`	`],`
Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ describe('ReactNative', () => {`
`218`	`218`	`ReactNative.setNativeProps(viewRef, {foo: 'baz'});`
`219`	`219`	`}).toWarnDev(`
`220`	`220`	`[`
`221`		`- "Warning: setNativeProps was called on a ref that isn't a " +`
	`221`	`+ "Warning: setNativeProps was called with a ref that isn't a " +`
`222`	`222`	`'native component. Use React.forwardRef to get access ' +`
`223`	`223`	`'to the underlying native component',`
`224`	`224`	`],`