Remove inexact-spread lint

gkz · facebook-github-bot · commit 759970c1b6dc · 2020-01-02T12:28:21.000-08:00
Summary: After jbrown215's changes to spread, this lint is no longer relevant.

Reviewed By: jbrown215

Differential Revision: D19241113

fbshipit-source-id: 6ea5b54fb6137a2b4b0ef220a429aca475abeb14
diff --git a/src/common/lints/lints.ml b/src/common/lints/lints.ml
@@ -34,7 +34,6 @@ type lint_kind =
   | DeprecatedUtility
   | DynamicExport
   | UnsafeGettersSetters
-  | InexactSpread
   | UnnecessaryOptionalChain
   | UnnecessaryInvariant
   | SignatureVerificationFailure
@@ -68,7 +67,6 @@ let string_of_kind = function
   | DeprecatedUtility -> "deprecated-utility"
   | DynamicExport -> "dynamic-export"
   | UnsafeGettersSetters -> "unsafe-getters-setters"
-  | InexactSpread -> "inexact-spread"
   | UnnecessaryOptionalChain -> "unnecessary-optional-chain"
   | UnnecessaryInvariant -> "unnecessary-invariant"
   | SignatureVerificationFailure -> "signature-verification-failure"
@@ -102,7 +100,6 @@ let kinds_of_string = function
   | "deprecated-utility" -> Some [DeprecatedUtility]
   | "dynamic-export" -> Some [DynamicExport]
   | "unsafe-getters-setters" -> Some [UnsafeGettersSetters]
-  | "inexact-spread" -> Some [InexactSpread]
   | "unnecessary-optional-chain" -> Some [UnnecessaryOptionalChain]
   | "unnecessary-invariant" -> Some [UnnecessaryInvariant]
   | "signature-verification-failure" -> Some [SignatureVerificationFailure]
diff --git a/src/common/lints/lints.mli b/src/common/lints/lints.mli
@@ -34,7 +34,6 @@ type lint_kind =
   | DeprecatedUtility
   | DynamicExport
   | UnsafeGettersSetters
-  | InexactSpread
   | UnnecessaryOptionalChain
   | UnnecessaryInvariant
   | SignatureVerificationFailure
diff --git a/src/typing/debug_js.ml b/src/typing/debug_js.ml
@@ -2917,8 +2917,6 @@ let dump_error_message =
     | EUnnecessaryOptionalChain (loc, _) ->
       spf "EUnnecessaryOptionalChain (%s)" (string_of_aloc loc)
     | EUnnecessaryInvariant (loc, _) -> spf "EUnnecessaryInvariant (%s)" (string_of_aloc loc)
-    | EInexactSpread (reason, reason_op) ->
-      spf "EInexactSpread (%s, %s)" (dump_reason cx reason) (dump_reason cx reason_op)
     | EUnexpectedTemporaryBaseType loc ->
       spf "EUnexpectedTemporaryBaseType (%s)" (string_of_aloc loc)
     | ECannotDelete (l1, r1) -> spf "ECannotDelete (%s, %s)" (string_of_aloc l1) (dump_reason cx r1)
diff --git a/src/typing/errors/error_message.ml b/src/typing/errors/error_message.ml
@@ -267,7 +267,6 @@ and 'loc t' =
   | EOptionalChainingMethods of 'loc
   | EUnnecessaryOptionalChain of 'loc * 'loc virtual_reason
   | EUnnecessaryInvariant of 'loc * 'loc virtual_reason
-  | EInexactSpread of 'loc virtual_reason * 'loc virtual_reason
   | EUnexpectedTemporaryBaseType of 'loc
   | ECannotDelete of 'loc * 'loc virtual_reason
   | EBigIntNotYetSupported of 'loc virtual_reason
@@ -734,7 +733,6 @@ let rec map_loc_of_error_message (f : 'a -> 'b) : 'a t' -> 'b t' =
   | EOptionalChainingMethods loc -> EOptionalChainingMethods (f loc)
   | EUnnecessaryOptionalChain (loc, r) -> EUnnecessaryOptionalChain (f loc, map_reason r)
   | EUnnecessaryInvariant (loc, r) -> EUnnecessaryInvariant (f loc, map_reason r)
-  | EInexactSpread (r1, r2) -> EInexactSpread (map_reason r1, map_reason r2)
   | EUnexpectedTemporaryBaseType loc -> EUnexpectedTemporaryBaseType (f loc)
   | ECannotDelete (l1, r1) -> ECannotDelete (f l1, map_reason r1)
   | EBigIntNotYetSupported r -> EBigIntNotYetSupported (map_reason r)
@@ -980,7 +978,6 @@ let util_use_op_of_msg nope util = function
   | EOptionalChainingMethods _
   | EUnnecessaryOptionalChain _
   | EUnnecessaryInvariant _
-  | EInexactSpread _
   | EUnexpectedTemporaryBaseType _
   | ECannotDelete _
   | EBigIntNotYetSupported _
@@ -1011,7 +1008,6 @@ let loc_of_msg : 'loc t' -> 'loc option = function
   | EComparison (primary, _)
   | EFunPredCustom ((primary, _), _)
   | EDynamicExport (_, primary)
-  | EInexactSpread (_, primary)
   | EInvalidTypeArgs (_, primary)
   | ETooFewTypeArgs (primary, _, _)
   | ETooManyTypeArgs (primary, _, _) ->
@@ -1226,7 +1222,6 @@ let kind_of_msg =
     | ESketchyNumberLint (kind, _) -> LintError (Lints.SketchyNumber kind)
     | EUnnecessaryOptionalChain _ -> LintError Lints.UnnecessaryOptionalChain
     | EUnnecessaryInvariant _ -> LintError Lints.UnnecessaryInvariant
-    | EInexactSpread _ -> LintError Lints.InexactSpread
     | ESignatureVerification _ -> LintError Lints.SignatureVerificationFailure
     | EImplicitInexactObject _ -> LintError Lints.ImplicitInexactObject
     | EAmbiguousObjectType _ -> LintError Lints.AmbiguousObjectType
@@ -2717,22 +2712,6 @@ let friendly_message_of_msg : Loc.t t' -> Loc.t friendly_message_recipe =
       ]
     in
     Normal { features }
-  | EInexactSpread (reason, reason_op) ->
-    let features =
-      [
-        text "Cannot determine the type of ";
-        ref reason_op;
-        text " because ";
-        text "it contains a spread of inexact ";
-        ref reason;
-        text ". ";
-        text "Being inexact, ";
-        ref reason;
-        text " might be missing the types of some properties that are being copied. ";
-        text "Perhaps you could make it exact?";
-      ]
-    in
-    Normal { features }
   | EBigIntNotYetSupported reason ->
     Normal { features = [text "BigInt "; ref reason; text " is not yet supported."] }
   | ECannotSpreadInterface { spread_reason; interface_reason } ->
@@ -3027,7 +3006,6 @@ let is_lint_error = function
   | EUnsafeGettersSetters _
   | ESketchyNullLint _
   | ESketchyNumberLint _
-  | EInexactSpread _
   | EBigIntNotYetSupported _
   | EUnnecessaryOptionalChain _
   | EUnnecessaryInvariant _
diff --git a/src/typing/flow_js.ml b/src/typing/flow_js.ml
@@ -5084,8 +5084,8 @@ struct
         with reads of those properties through X as soon as O2 is resolved. To
         avoid this race, we make O2 flow to ObjAssignToT(_,O1,X,ObjAssign);
         when O2 is resolved, we make the switch. **)
-        | ( DefT (lreason, _, ObjT { props_tmap = mapr; flags; dict_t; _ }),
-            ObjAssignFromT (use_op, reason_op, to_obj, t, ObjAssign error_flags) ) ->
+        | ( DefT (lreason, _, ObjT { props_tmap = mapr; dict_t; _ }),
+            ObjAssignFromT (use_op, reason_op, to_obj, t, ObjAssign _) ) ->
           Context.iter_props cx mapr (fun x p ->
               (* move the reason to the call site instead of the definition, so
            that it is in the same scope as the Object.assign, so that
@@ -5110,11 +5110,8 @@ struct
                   (Error_message.EPropNotReadable { reason_prop; prop_name = Some x; use_op }));
           if dict_t <> None then
             rec_flow_t cx trace ~use_op (AnyT.make Untyped reason_op, t)
-          else (
-            if error_flags.assert_exact && not flags.exact then
-              add_output cx ~trace (Error_message.EInexactSpread (lreason, reason_op));
+          else
             rec_flow_t cx trace ~use_op (to_obj, t)
-          )
         | ( DefT (lreason, _, InstanceT (_, _, _, { own_props; proto_props; _ })),
             ObjAssignFromT (use_op, reason_op, to_obj, t, ObjAssign _) ) ->
           let own_props = Context.find_props cx own_props in
diff --git a/tests/spread/.flowconfig b/tests/spread/.flowconfig
@@ -1,6 +1,3 @@
 [options]
 no_flowlib=false
 all=true
-
-[lints]
-inexact-spread=error
