Tags: facebook/buck2
Tags
Fix github ci windows-build-and-test by allow unused variable Summary: https://github.com/facebook/buck2/actions/runs/17330648823/job/49205577725 On github ci windows-build-and-test we got such issue ``` error: unused variable: `enable_action_cgroup_pool` --> app\buck2_common\src\resource_control.rs:119:9 | 119 | enable_action_cgroup_pool: bool, | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_enable_action_cgroup_pool` | = note: requested on the command line with `-D unused-variables` ``` This is because on windows we don't use this flag. Set it to allow unused_variables. We need to do some refactor later. Reviewed By: JakobDegen Differential Revision: D81339160 fbshipit-source-id: 5d6f8ea1c4d2e70cce1cce269e91ce120664de6d
Allow clippy::uninlined_format_args Summary: This lint is failing buck2-oss jobs on revisions that used to pass, I can repro it with codesync but not directly in the repo, despite the fact that codesync does not modify any relevant code. It's unclear to me how a lint could be flaky, presumably it's not the lint itself, but in any case this doesn't seem useful and it's disabled elsewhere in the repo. Reviewed By: Will-MingLun-Li Differential Revision: D80303763 fbshipit-source-id: 23f8b83422bacd8efca2953839ab827c5114ae4e
Make KIC default Summary: ### Context We are integrating the Kotlin Incremental Compiler (KSIC) into Buck to enable incremental compilation of Kotlin source files. This aims to enhance build speed by recompiling only modified source files within a target, rather than rebuilding the entire target. ### This diff After testing on IG and WA, KIC will be the default option for all Kotlin targets. *Note: This change will be announced by a public post before landing.* Reviewed By: IanChilds Differential Revision: D79264690 fbshipit-source-id: 44d4b0fd7db301ff80f96f08109873e6e1acf433
file watcher: Make a watchman test more flexible Summary: Test is flakey. Idk what's going on in watchman Reviewed By: scottcao Differential Revision: D78302620 fbshipit-source-id: 6db777df93c8097257606137830209f6263ffc29
Don't save inputs if we're never going to use them Summary: If we're never going to run dep-files (because there are no dep-files declared), then we do not need to create `shared_declared_inputs`, since we'll never use them anyway. Reviewed By: scottcao Differential Revision: D75438242 fbshipit-source-id: b0667628a6145fbba194e2c81f98c70dee4058ef
Fix up broken buck2_explain test Summary: Slightly ironic that buck2 explain test case started failing right after iguridi left. The issue seems to be that BUCK_WRAPPER_UUID was not set for the first build command which launched the daemon, so env var was not propagated properly. Not sure why it was working before. Maybe someone was trying this locally and it caused the corresponding log to be populated in manifold and the TTL only expired recently. Reviewed By: JakobDegen Differential Revision: D76648150 fbshipit-source-id: ca556341358bbb1714e7e13db40e4fb1a2814086
Add A/B test logic for FileNotFound errors Summary: Making it possible to A/B test FileNotFound changes and see how it will affect Time to Fix Reviewed By: IanChilds Differential Revision: D75332660 fbshipit-source-id: 359de6f6382147c89f0d2b1f5ca4ed2c63b1fb66
Add namesapce to global Summary: RFC: https://fb.workplace.com/groups/buck2dev/permalink/3984941291793913/ This diff adds `namespace` to global, will be used in the later diff to help generate docs Reviewed By: JakobDegen Differential Revision: D73700604 fbshipit-source-id: 319d03cb6f64aa2028690f16f7d244b2f26772c5
Back out "Use `--undefined-glob` to mark undefined syms" Summary: This is causing omnibus linking to slow dramatically. https://fb.workplace.com/groups/llvm.gcc/permalink/28374999635455282/ Reviewed By: JakobDegen Differential Revision: D73954741 fbshipit-source-id: 0572b05f1da0d99aae6c84748a5227797de72877
Refactor version info propagation Summary: Re-use GITHUB_OUTPUTs to grab version information and simplify the build step. Reviewed By: Will-MingLun-Li Differential Revision: D72233407 fbshipit-source-id: baf6b5a692fef84f39d36bc450d28039501ac2cb
PreviousNext