Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: fujiwara/tfstate-lookup
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.1
Choose a base ref
...
head repository: fujiwara/tfstate-lookup
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.4.2
Choose a head ref
  • 9 commits
  • 4 files changed
  • 3 contributors

Commits on Sep 14, 2024

  1. fix(lookup): improve quoteJQQuery function reliability 

    - Add a lookup test that failed when having object with dashes in the
  name after the scanned object name.
- Fix the quoteJQQuery to pass the test.
- Unify the quoteJQQuery processing algorithm for all queries, so no
  special behavior is used for queries with dashes.
    @qg-m-kondratenko
    qg-m-kondratenko committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    488e0a8 View commit details
    Browse the repository at this point in the history

  2. fix(lookup): allow for negative indexes in quoteJQQuery 

    - Add a lookup test with negative index.
- Fix quoteJQQuery to allow for negative indexes.
    @qg-m-kondratenko
    qg-m-kondratenko committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    254c991 View commit details
    Browse the repository at this point in the history

  3. chore(gitignore): add compiled binary to gitignore 

    Add binary, built with go build to gitignore, so it does not
accidentally get commited.
    @qg-m-kondratenko
    qg-m-kondratenko committed Sep 14, 2024
    Configuration menu
    Copy the full SHA
    e1a6f64 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Merge pull request #205 from qgrp-m-kondratenko/main 

    Improve quoteJQQuery reliability
    @fujiwara
    fujiwara authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    de69972 View commit details
    Browse the repository at this point in the history

  2. add benchmark 

    goos: linux
goarch: amd64
pkg: github.com/fujiwara/tfstate-lookup/tfstate
cpu: AMD Ryzen 5 3400G with Radeon Vega Graphics
BenchmarkLookupFile-8               3056            374179 ns/op          210225 B/op       2549 allocs/op
PASS
    @fujiwara
    fujiwara committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2ac40ae View commit details
    Browse the repository at this point in the history

  3. regexp.MustCompile outside in the function 

    goos: linux
goarch: amd64
pkg: github.com/fujiwara/tfstate-lookup/tfstate
cpu: AMD Ryzen 5 3400G with Radeon Vega Graphics
BenchmarkLookupFile-8               5895            197672 ns/op          109939 B/op       1171 allocs/op
PASS
    @fujiwara
    fujiwara committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f4fcddc View commit details
    Browse the repository at this point in the history

  4. short cut

    @fujiwara
    fujiwara committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    2ceb58a View commit details
    Browse the repository at this point in the history

  5. simplify 

    goos: linux
goarch: amd64
pkg: github.com/fujiwara/tfstate-lookup/tfstate
cpu: AMD Ryzen 5 3400G with Radeon Vega Graphics
BenchmarkLookupFile-8               7789            143841 ns/op           89158 B/op        854 allocs/op
PASS
    @fujiwara
    fujiwara committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    485732a View commit details
    Browse the repository at this point in the history

  6. Merge pull request #206 from fujiwara/fix/performance 

    Fix/performance
    @fujiwara
    fujiwara authored Sep 17, 2024
    Configuration menu
    Copy the full SHA
    4b5e629 View commit details
    Browse the repository at this point in the history
Loading