Skip to content

feat: add --public flag for port forwarding to bind on all interfaces #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2025
Merged

feat: add --public flag for port forwarding to bind on all interfaces #91

merged 3 commits into from
Jun 6, 2025

Conversation

fujiwara
Copy link
Owner

@fujiwara fujiwara commented Jun 6, 2025

Summary

  • Add --public flag to enable port forwarding on all interfaces (0.0.0.0) instead of localhost only
  • Implement pure Go TCP proxy to forward traffic from 0.0.0.0 to Session Manager Plugin on 127.0.0.1
  • Resolve port binding conflicts by using ephemeral ports for Session Manager Plugin when --public is specified

Changes

  • New --public flag: Simple boolean flag to enable public access
  • TCP Proxy Implementation: Pure Go implementation with bidirectional data forwarding
  • Port Conflict Resolution: Smart port allocation to avoid 127.0.0.1 vs 0.0.0.0 binding conflicts
  • Enhanced Logging: Structured logging with security warnings and connection details
  • Comprehensive Tests: Unit and integration tests for new functionality

Technical Details

  • No External Dependencies: No socat or other external tools required
  • Context-Aware: Proper context handling for graceful shutdown
  • Security Warning: Alerts users when binding to all interfaces
  • Ephemeral Port Strategy: Pre-allocates specific ephemeral ports to avoid race conditions

Testing

Tested with external connections showing successful proxy operation:

2025-06-07T01:41:13.048+09:00 [WARN] TCP proxy will bind to all interfaces (0.0.0.0)
2025-06-07T01:41:13.048+09:00 [INFO] Session Manager Plugin will use port [port:39133]
2025-06-07T01:41:13.048+09:00 [INFO] TCP proxy listening [address:0.0.0.0:9999]
2025-06-07T01:41:47.993+09:00 [DEBUG] proxying connection [client:100.118.212.19:43368]

Benefits

  • Docker Access: Enables access from Docker containers without socat workaround
  • Network Flexibility: Supports access from any network interface
  • Backward Compatibility: Default behavior unchanged (localhost only)
  • Clean Implementation: Simple, maintainable code structure

Fixes #83

🤖 Generated with Claude Code

fujiwara and others added 2 commits June 7, 2025 01:44
@fujiwara @claude
feat: add --public flag for port forwarding to bind on all interfaces
30ea1e3 
- Add --public flag to PortforwardOption to enable binding on 0.0.0.0
- Implement TCP proxy functionality to forward from 0.0.0.0 to localhost
- Use ephemeral ports for Session Manager Plugin when --public is specified
- Add bidirectional TCP proxy with proper connection handling and context cancellation
- Resolve port binding conflicts between Session Manager Plugin and public access
- Enable Docker container access without requiring socat workaround

Fixes #83

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@fujiwara @claude
fix: improve TCP proxy test reliability and goroutine management
bbf83e8 
- Add proper context-based listener shutdown in startTCPProxyToLocalhost
- Fix integration tests to terminate correctly without goroutine leaks
- Implement timeout handling and proper resource cleanup in tests
- Ensure all tests pass with race detection enabled
- Maintain test coverage while fixing CI reliability issues
- Update .gitignore to exclude build artifacts and test data

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@fujiwara fujiwara force-pushed the add-public-port-binding branch from 26ee670 to bbf83e8 Compare June 6, 2025 17:05
@fujiwara @claude
fix: translate Japanese comments to English in test files
b2fc4b0 
- Convert Japanese comments in portforward_test.go to English
- Maintain consistent English-only codebase for international collaboration

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@fujiwara fujiwara merged commit b072fc7 into main Jun 6, 2025
4 checks passed
@fujiwara fujiwara deleted the add-public-port-binding branch June 6, 2025 17:11
@github-actions github-actions bot mentioned this pull request Jun 6, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow binding to public 0.0.0.0 address
1 participant
@fujiwara