Skip to content

Commit 3ca6852

Browse files
committed
fix(ngTableParams): parameters method returns incorrect object
`parameters` method when called without arguments should return the current `ParamValues`, but instead is returning a reference to `this`
1 parent 0966428 commit 3ca6852

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/core/ngTableParams.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -385,7 +385,7 @@ export class NgTableParams<T> {
385385
parameters(newParameters?: ParamValues<T> | { [name: string]: string }, parseParamsFromUrl?: boolean): this
386386
parameters(newParameters?: ParamValues<T> | { [name: string]: string }, parseParamsFromUrl?: boolean): ParamValues<T> | this {
387387
parseParamsFromUrl = parseParamsFromUrl || false;
388-
if (typeof newParameters !== undefined) {
388+
if (newParameters !== undefined) {
389389
for (const key in newParameters) {
390390
let value = newParameters[key];
391391
if (parseParamsFromUrl && key.indexOf('[') >= 0) {

0 commit comments

Comments
 (0)