Skip to content

Commit 6e810ba

Browse files
ccrowhurstramccrowhurstram
committed
feat(ngTableSettings): nested options never undefined
This is part of supporting typescript strictNullChecks compiler option BREAKING CHANGES `ISettings`: replaced with `Settings` class and a type alias of `SettingsPartial` `Settings.interceptors`, `Settings.counts`: arrays are cloned therefore any changes to the array will not be recognised `settings(newSettings)`: any setting value supplied as undefined will now be ignored. Instead of `undefined` you will need to supply a suitable value as described below: * `counts` - an empty array to prevent the page size buttons rendering * `filterOptions.filterDelay` - `0` to remove the debounce delay * `filterOptions.filterDelayThreshold` - `null` so that a `dataset` of any size will have a `filterDelay` applied * `groupOptions.sortDirection` - `''` so that grouped columns are NOT sorted by default * `groupOptions.isExpanded` - `false` so that each grouped set of rows are collapsed by default * `paginationMaxBlocks`, `paginationMinBlocks` - `0`
1 parent 5317463 commit 6e810ba

29 files changed

+783
-424
lines changed

‎.gitignore

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,12 @@ e2e/**/*.d.ts
1616
!e2e/protractor*.js
1717
!demo-apps/es5/index.js
1818
!demo-apps/es6-systemjs/index.js
19-
test/**/*.d.ts
20-
test/**/*.js.map
21-
test/**/*.js
22-
!test/index.js
23-
!test/index.d.ts
19+
test/specs/**/*.d.ts
20+
test/specs/**/*.js.map
21+
test/specs/**/*.js
22+
test/util/**/*.d.ts
23+
test/util/**/*.js.map
24+
test/util/**/*.js
2425
bundles
2526
build
2627
build-stats.json

‎.vscode/settings.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,11 @@
1515
"**/.git": true,
1616
"**/.DS_Store": true,
1717
"**/*.js": {"when": "$(basename).ts"},
18+
"**/*.js.map": true,
19+
"*.d.ts": true,
1820
"src/**/*.d.ts": true,
19-
"src/**/*.js.map": true,
20-
"test/**/*.d.ts": true,
21-
"test/**/*.js.map": true,
21+
"test/specs/**/*.d.ts": true,
22+
"test/util/**/*.d.ts": true,
2223
"bundles/": true,
2324
"demo-apps/**/build/": true,
2425
"demo-site/api-docs/": true,

‎demo-apps/ts-webpack/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"build": "node ../../node_modules/webpack/bin/webpack.js --env.debug",
1212
"prebuild:prod": "npm run clean",
1313
"build:prod": "node ../../node_modules/webpack/bin/webpack.js --progress --env.prod",
14-
"clean": "node ../../node_modules/shx/lib/cli.js rm -rf build build-stats.json src/**/*.js src/**/*.js.map",
14+
"clean": "node ../../node_modules/shx/lib/cli.js rm -rf build build-stats.json src/**/*.{js,js.map}",
1515
"linklocal": "npm run _linklocal && npm prune",
1616
"serve": "node ../../node_modules/http-server/bin/http-server build -c-1 -o",
1717
"start": "node ../../node_modules/webpack-dev-server/bin/webpack-dev-server.js --progress --env.debug --open",

‎karma.conf.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ module.exports = function (config) {
1717
// list of files / patterns to load in the browser
1818
files: [
1919
// libraries
20-
'node_modules/lodash/index.js',
20+
'node_modules/lodash/lodash.js',
2121
'node_modules/angular/angular.js',
2222
'node_modules/angular-mocks/angular-mocks.js',
2323
testGlob

0 commit comments

Comments
 (0)