Skip to content

Conversation

mck89
Copy link
Contributor

@mck89 mck89 commented Nov 26, 2019

Closes #202

@RReverser
Copy link
Member

@loganfsmyth What do you think about this vs ExportNamespaceDeclaration? (adding to reviewers as you had some concerns)

@mysticatea
Copy link
Contributor

For what it's worth, I think that ExportAllDeclaration is proper because it takes all members from "source" then exports them. The word "all" affects to source rather than destination, so we can write other export declarations even if ExportAllDeclaration existed.

@mysticatea
Copy link
Contributor

If ExportAllDeclaration means "it exports an ambiguous number of elements (in other words, it needs to load more files to decide the number of exported elements)," then using ExportNamedDeclaration is reasonable. But ModuleSpecifier has local property always, we should fix it.

@mck89
Copy link
Contributor Author

mck89 commented Dec 19, 2019

Any update about this?

@jdalton
Copy link

jdalton commented Jan 25, 2020

Just fyi this PR is holding up support in projects like acorn.

@kaicataldo
Copy link

One more friendly ping here.

Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the property name, but it's not a big deal.

@bradzacher
Copy link

Friendly ping here, as this is holding up support for TS3.8 features in typescript-eslint (and thus in prettier as well).

Copy link
Member

@RReverser RReverser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export * as ns from "source" representation
7 participants