Skip to content

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jun 12, 2025

Prerequisites checklist

What is the purpose of this pull request?

To allow rule configs to have an array with just a severity:

{
    rules: {
        semi: ["error"]
    }
}

What changes did you make? (Give an overview)

  • Updated RuleConfig to also match [Severity].
  • Updated types tests to verify this change.

Related Issues

Split from eslint/eslint#19843 (comment)

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 12, 2025
@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Jun 12, 2025
@nzakas nzakas marked this pull request as draft June 12, 2025 20:41
@nzakas nzakas marked this pull request as ready for review June 17, 2025 15:08
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Would like @fasttime to verify.

@mdjermanovic mdjermanovic moved this from Needs Triage to Second Review Needed in Triage Jun 17, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit c5f92fa into main Jun 18, 2025
21 checks passed
@fasttime fasttime deleted the ruleconfig-update branch June 18, 2025 04:43
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jun 18, 2025
@github-actions github-actions bot mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants