Skip to content

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Apr 30, 2025

Prerequisites checklist

What is the purpose of this pull request?

Fix the release.

What changes did you make? (Give an overview)

  • Rolls back the change to have separate PRs for each package. Dependencies don't get properly updated when we have separate PRs.
  • Updates @eslint/core in each package that needs it.

Related Issues

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Apr 30, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Apr 30, 2025
@fasttime
Copy link
Member

fasttime commented Apr 30, 2025

When I tested the release with separate PRs, I saw that dependencies were being properly updated after a release. So for example, after merging the release PR for @eslint/core, release-please force-pushed a commit to the other PRs so that each dependent package would use the updated version of @eslint/core in their package.json files. I'm not sure why this didn't happen in this repo after merging #194. Maybe you were merging too fast? For example in #192, which is still unmerged, @eslint/core is correctly updated to 0.14.0.

@nzakas
Copy link
Member Author

nzakas commented Apr 30, 2025

This happened immediately upon merging #194 (I just didn't notice):
https://github.com/eslint/rewrite/actions/runs/14758801927/job/41433982243

Because npm run build builds all of the packages, when it tried to build @eslint/plugin-kit, it failed because it's package.json had not updated yet. To avoid that, #194 would have had to update all of the package.json files.

@fasttime
Copy link
Member

fasttime commented May 1, 2025

It's true, for some reason after @eslint/core was merged with #194 there was a force-pushed commit in #190 that switched back to using "@eslint/core": "^0.13.0" as a dependency in packages/plugin-kit/package.json.

-   "@eslint/core": "^0.14.0",
+   "@eslint/core": "^0.13.0",

https://github.com/eslint/rewrite/compare/33844b5b47e27905842340c6fb6a54698f51771e..a98b3a55561750f6e32c0b028f85a13e1a7776c0

It's not clear me why this happened.

Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit a830283 into main May 1, 2025
18 checks passed
@fasttime fasttime deleted the release-fix branch May 1, 2025 09:10
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage May 1, 2025
@github-actions github-actions bot mentioned this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants