Skip to content

fix: don't recognize directives in ES3, allow parenthesized rest target #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix: don't recognize directives in ES3, allow parenthesized rest target #554

merged 1 commit into from
Jul 21, 2022

Conversation

mdjermanovic
Copy link
Member

Upgrades acorn dependency to v8.8.0 to include two bug fixes:

  1. In ES3, directives should not be recognized.
    issue: in es3, "use strict" should not be parsed as directive acornjs/acorn#1126
    fix: acornjs/acorn@9c2cad5
  2. Destructuring assignment target in rest properties can be parenthesized.
    issue: Destructuring assignment to grouped spread arg should pass acornjs/acorn#872
    fix: acornjs/acorn@fb4afde

nzakas
nzakas approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit b1eac6d into main Jul 21, 2022
@nzakas nzakas deleted the acorn-8.8.0 branch July 21, 2022 23:57
@btmills btmills mentioned this pull request Jul 31, 2022
Merged
1 task
@mdjermanovic mdjermanovic mentioned this pull request Aug 23, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
accepted bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdjermanovic @nzakas