-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: default value of accessor-pairs option in rule.d.ts file #20024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for docs-eslint canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@Tanujkanti4441 Could you merge the main branch when you have time? The CI failure should be resolved now since #20023 has been merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`9.33.0` -> `9.34.0`](https://renovatebot.com/diffs/npm/eslint/9.33.0/9.34.0) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v9.34.0`](https://github.com/eslint/eslint/releases/tag/v9.34.0) [Compare Source](eslint/eslint@v9.33.0...v9.34.0) #### Features - [`0bb777a`](eslint/eslint@0bb777a) feat: multithread linting ([#​19794](eslint/eslint#19794)) (Francesco Trotta) - [`43a5f9e`](eslint/eslint@43a5f9e) feat: add eslint-plugin-regexp to eslint-config-eslint base config ([#​19951](eslint/eslint#19951)) (Pixel998) #### Bug Fixes - [`9b89903`](eslint/eslint@9b89903) fix: default value of accessor-pairs option in rule.d.ts file ([#​20024](eslint/eslint#20024)) (Tanuj Kanti) - [`6c07420`](eslint/eslint@6c07420) fix: fix spurious failure in neostandard integration test ([#​20023](eslint/eslint#20023)) (Kirk Waiblinger) - [`676f4ac`](eslint/eslint@676f4ac) fix: allow scientific notation with trailing zeros matching exponent ([#​20002](eslint/eslint#20002)) (Sweta Tanwar) #### Documentation - [`0b4a590`](eslint/eslint@0b4a590) docs: make rulesdir deprecation clearer ([#​20018](eslint/eslint#20018)) (Domenico Gemoli) - [`327c672`](eslint/eslint@327c672) docs: Update README (GitHub Actions Bot) - [`bf26229`](eslint/eslint@bf26229) docs: Fix typo in core-concepts/index.md ([#​20009](eslint/eslint#20009)) (Tobias Hernstig) - [`2309327`](eslint/eslint@2309327) docs: fix typo in the "Configuring Rules" section ([#​20001](eslint/eslint#20001)) (ghazi-git) - [`2b87e21`](eslint/eslint@2b87e21) docs: \[no-else-return] clarify sample code. ([#​19991](eslint/eslint#19991)) (Yuki Takada (Yukinosuke Takada)) - [`c36570c`](eslint/eslint@c36570c) docs: Update README (GitHub Actions Bot) #### Chores - [`f19ad94`](eslint/eslint@f19ad94) chore: upgrade to `@eslint/js@9.34.0` ([#​20030](eslint/eslint#20030)) (Francesco Trotta) - [`b48fa20`](eslint/eslint@b48fa20) chore: package.json update for [@​eslint/js](https://github.com/eslint/js) release (Jenkins) - [`4bce8a2`](eslint/eslint@4bce8a2) chore: package.json update for eslint-config-eslint release (Jenkins) - [`0c9999c`](eslint/eslint@0c9999c) refactor: prefer default options in `grouped-accessor-pairs` ([#​20028](eslint/eslint#20028)) (루밀LuMir) - [`d503f19`](eslint/eslint@d503f19) ci: fix `stale.yml` ([#​20010](eslint/eslint#20010)) (루밀LuMir) - [`e2dc67d`](eslint/eslint@e2dc67d) ci: centralize `stale.yml` ([#​19994](eslint/eslint#19994)) (루밀LuMir) - [`7093cb8`](eslint/eslint@7093cb8) ci: bump actions/checkout from 4 to 5 ([#​20005](eslint/eslint#20005)) (dependabot\[bot]) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS42MS4wIiwidXBkYXRlZEluVmVyIjoiNDEuNjEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Reviewed-on: https://git.robbevp.be/robbevp/website-robbevanpetegem/pulls/495 Co-authored-by: Renovate Bot <renovate@robbevp.be> Co-committed-by: Renovate Bot <renovate@robbevp.be>
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
changed the default value of
enforceForTSTypes
option ofaccessor-pairs
rule inrule.d.ts
file tofalse
which istrue
right now.eslint/lib/rules/accessor-pairs.js
Lines 149 to 156 in 676f4ac
Is there anything you'd like reviewers to focus on?