Skip to content

Conversation

TKDev7
Copy link
Contributor

@TKDev7 TKDev7 commented Jul 8, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added retry logic to the outputFixes method to handle EMFILE errors when writing autofix results. This prevents ESLint from crashing if the system runs out of file descriptors during autofix operations.

Fixes #19924

Is there anything you'd like reviewers to focus on?

@TKDev7 TKDev7 requested a review from a team as a code owner July 8, 2025 17:58
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 8, 2025
Copy link

netlify bot commented Jul 8, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit db3be7e
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/686e4fdbea84750008b5b015

@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jul 8, 2025
@github-actions github-actions bot added cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features labels Jul 8, 2025
@fasttime fasttime moved this from Needs Triage to Implementing in Triage Jul 9, 2025
@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 9, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic LGMT. I left a comment about the test.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Leaving open for @fasttime to verify this is ready for merge.

@nzakas nzakas moved this from Implementing to Second Review Needed in Triage Jul 9, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit 07fac6c into eslint:main Jul 10, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly cli Relates to ESLint's command-line interface contributor pool core Relates to ESLint's core APIs and features
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: running --fix throws EMFILE: too many open files
4 participants