fix: Remove incorrect RuleContext types #19910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
aladdin-add
approved these changes
Jul 3, 2025
1 task
mureinik
added a commit
to mureinik/eslint-plugin-n
that referenced
this pull request
Jul 25, 2025
eslint@9.31.0 removed some of the RuleContext types (see eslint/eslint#19910), causing the `test:types` CI script to fail. As a quick fix to unblock further development, we can lock down the eslint dependency to 9.30.1, where these types still exist, until a "proper" solution can be developed. Fixes eslint-community#459
mureinik
added a commit
to mureinik/eslint-plugin-n
that referenced
this pull request
Jul 25, 2025
eslint@9.31.0 removed some of the RuleContext types (see eslint/eslint#19910), causing the `test:types` CI script to fail. Since eslint-plugin-n still needs to support 8.x versions of eslint, the implementation that relies on RuleContexts can't be removed. A simple solution to unblock the CI is to annotate the few places that rely on them with @ts-ignore. When eslint 8.x support is dropped, these annotations should be removed. That, in turn, will expose the code that relies on eslint 8.x APIs, which should then also be removed. As part of this PR, the eslint dependency was bumped to ^9.31.0. This was done in order to prevent developers from developing locally with older 9.x versions of eslint and accidentally introducing new code that relies of these types with properly handling the type annotations and having it fail in the CI. Fixes eslint-community#459
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Removed type definitions and related tests for:
context.getAncestors()context.getDeclaredVariables(AST)context.getScope()context.markVariableAsUsed("foo")fixes #19903
Is there anything you'd like reviewers to focus on?