Skip to content

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jun 30, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Clarified expectations around who is responsible for issues. This mostly just documents what we've already been doing in a clearer way.

fixes #19900

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner June 30, 2025 18:05
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 30, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 30, 2025
Copy link

netlify bot commented Jun 30, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 96add4a
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6864307f36da4a00081ee610
😎 Deploy Preview https://deploy-preview-19902--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@amareshsm amareshsm moved this from Needs Triage to Triaging in Triage Jun 30, 2025
@amareshsm amareshsm added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 30, 2025
lumirlumir
lumirlumir previously approved these changes Jul 1, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no particular comments from my side 👍

aladdin-add
aladdin-add previously approved these changes Jul 1, 2025
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Co-authored-by: Amaresh  S M  <amareshsm13@gmail.com>
@nzakas nzakas dismissed stale reviews from aladdin-add and lumirlumir via 96add4a July 1, 2025 19:01
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amareshsm amareshsm moved this from Triaging to Merge Candidates in Triage Jul 1, 2025
@aladdin-add aladdin-add requested a review from mdjermanovic July 1, 2025 19:18
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit fef04b5 into main Jul 2, 2025
30 of 31 checks passed
@mdjermanovic mdjermanovic deleted the issue19900 branch July 2, 2025 15:33
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Docs: Define expectations around ownership of issues and PRs
7 participants