Skip to content

fix: allow any type for meta.docs.recommended in custom rules #19995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Aug 8, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Update core types and documentation.

refs eslint/rewrite#234

What changes did you make? (Give an overview)

  • Updated @eslint/core to allow arbitrary types for meta.docs.recommended in custom rules.
  • @eslint/config-helpers and @eslint/plugin-kit have been updated to the latest versions.
  • Updated type tests and documentation.

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Aug 8, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Aug 8, 2025
Copy link

netlify bot commented Aug 8, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 30f90c0
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6895d8228e533c0008f0a570
😎 Deploy Preview https://deploy-preview-19995--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fasttime fasttime marked this pull request as ready for review August 8, 2025 11:07
@fasttime fasttime requested a review from a team as a code owner August 8, 2025 11:07
@fasttime fasttime added types Related to TypeScript types accepted There is consensus among the team that this change meets the criteria for inclusion labels Aug 8, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Aug 8, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

If anyone else is available, another review would be appreciated.

Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 732433c into main Aug 8, 2025
31 checks passed
@nzakas nzakas deleted the relax-recommended-type branch August 8, 2025 13:58
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly types Related to TypeScript types
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants