Skip to content

docs: add missing let declarations in no-plusplus #19980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 2, 2025

Conversation

Yukinosuke-Takada
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

added missing let declarations in for loop initializers

Is there anything you'd like reviewers to focus on?

@Yukinosuke-Takada Yukinosuke-Takada requested a review from a team as a code owner August 2, 2025 03:11
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Aug 2, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Aug 2, 2025
Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit b9b6019
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/688d81fc8f1a7700086f3b1a
😎 Deploy Preview https://deploy-preview-19980--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Yukinosuke-Takada Yukinosuke-Takada changed the title fix: add missing let declarations in for loop initializers docs: [no-plusplus] add missing let declarations in for loop initializers Aug 2, 2025
@eslint-github-bot
Copy link

Hi @Yukinosuke-Takada!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The length of the commit message must be less than or equal to 72

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@Yukinosuke-Takada Yukinosuke-Takada changed the title docs: [no-plusplus] add missing let declarations in for loop initializers docs: [no-plusplus] add missing let declarations Aug 2, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Aug 2, 2025
@mdjermanovic mdjermanovic changed the title docs: [no-plusplus] add missing let declarations docs: add missing let declarations in no-plusplus Aug 2, 2025
@mdjermanovic mdjermanovic removed the bug ESLint is working incorrectly label Aug 2, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Triaging in Triage Aug 2, 2025
@mdjermanovic mdjermanovic added the rule Relates to ESLint's core rules label Aug 2, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 247e156 into eslint:main Aug 2, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Aug 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants