-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
docs: Update no-multi-assign.md #19979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fix: typo
The committers listed above are authorized under a signed CLA. |
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi @Yukinosuke-Takada!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
@Yukinosuke-Takada thanks for the pull request, but I don't see an issue with the current code example. Can you clarify? |
Nothing critical—the sample code works fine, but I wanted to unify the logic.
Alternatively, we could change the |
Thanks! Correct and incorrect rule examples don't always come in pairs, and usually we don't make efforts to keep them in sync. Since this pull request is ready and looking good, it's fine to merge it this time. |
fix: typo
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
fix typo.
Is there anything you'd like reviewers to focus on?
Assuming the "correct code" section is right, the "incorrect code" section should follow the same logic.