Skip to content

docs: Update no-multi-assign.md #19979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025
Merged

Conversation

Yukinosuke-Takada
Copy link
Contributor

@Yukinosuke-Takada Yukinosuke-Takada commented Aug 2, 2025

fix: typo

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

fix typo.

Is there anything you'd like reviewers to focus on?

Assuming the "correct code" section is right, the "incorrect code" section should follow the same logic.

@Yukinosuke-Takada Yukinosuke-Takada requested a review from a team as a code owner August 2, 2025 02:28
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Aug 2, 2025
Copy link

linux-foundation-easycla bot commented Aug 2, 2025

CLA Signed

  • ✅login: Yukinosuke-Takada / (fc39717)

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Aug 2, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit fc39717
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/688d77c293ec3e00080fafeb
😎 Deploy Preview https://deploy-preview-19979--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslint-github-bot
Copy link

Hi @Yukinosuke-Takada!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@Yukinosuke-Takada Yukinosuke-Takada changed the title Update no-multi-assign.md docs: Update no-multi-assign.md Aug 2, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Aug 2, 2025
@fasttime fasttime moved this from Needs Triage to Triaging in Triage Aug 2, 2025
@fasttime
Copy link
Member

fasttime commented Aug 2, 2025

@Yukinosuke-Takada thanks for the pull request, but I don't see an issue with the current code example. Can you clarify?

@fasttime fasttime added the needs info Not enough information has been provided to triage this issue label Aug 2, 2025
@Yukinosuke-Takada
Copy link
Contributor Author

Nothing critical—the sample code works fine, but I wanted to unify the logic.
correct section is:

let d = c;
let e = c;

incorrect section is:

let d =
    e =
    f; // should be `c`.

Alternatively, we could change the correct section to use = f instead.

@fasttime
Copy link
Member

fasttime commented Aug 4, 2025

Nothing critical—the sample code works fine, but I wanted to unify the logic. correct section is:

let d = c;
let e = c;

incorrect section is:

let d =
    e =
    f; // should be `c`.

Alternatively, we could change the correct section to use = f instead.

Thanks! Correct and incorrect rule examples don't always come in pairs, and usually we don't make efforts to keep them in sync. Since this pull request is ready and looking good, it's fine to merge it this time.

@fasttime fasttime moved this from Triaging to Implementing in Triage Aug 4, 2025
@fasttime fasttime removed the needs info Not enough information has been provided to triage this issue label Aug 4, 2025
@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 4, 2025
@fasttime fasttime merged commit 5a4b6f7 into eslint:main Aug 4, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants