Skip to content

test: switch to Linter.Config in ESLintRules type tests #19977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2025

Conversation

fasttime
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Update type tests

This pull request updates the type tests, specifically for ESLintRules, to use Linter.Config instead of Linter.LegacyConfig. This will be necessary in order to remove the deprecated Linter.LegacyConfig type.

What changes did you make? (Give an overview)

Switched Linter.LegacyConfig to Linter.Config in type tests.

Is there anything you'd like reviewers to focus on?

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 30, 2025
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jul 30, 2025
Copy link

netlify bot commented Jul 30, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit a255b5b
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/688a427978b7640008724c92

@fasttime fasttime marked this pull request as ready for review July 30, 2025 16:12
@fasttime fasttime requested a review from a team as a code owner July 30, 2025 16:12
@fasttime fasttime added the types Related to TypeScript types label Jul 30, 2025

eslintConfig = {
rules: {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything else looks clean!

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 54920ed into main Jul 31, 2025
30 checks passed
@nzakas nzakas deleted the ESLintRules-test-flat branch July 31, 2025 15:19
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore This change is not user-facing types Related to TypeScript types
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants