-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
fix: Fixed potential bug in check-emfile-handling.js #19975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The committers listed above are authorized under a signed CLA. |
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Hi, @suwakei. Thanks for opening the PR. It looks like the CI is currently failing. Could you take a look at it when you have some time? |
@lumirlumir |
The CI failure seems to be caused by a 503 error when trying to install Python 3.13.5 via mise. |
The CI failure is unrelated to this PR. It looks like a momentary glitch in Netlify. |
Thanks for confirming! Let me know if I should re-run the CI or if it's good to go as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
I did re-run and everything passed. It just didn't update the display. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Problem:
On Linux and macOS, the command ulimit -n checks the maximum number of files that can be opened at one time. However, if this setting is set to "unlimited," the script will try to convert the string "unlimited" to a number and will fail (resulting in NaN) and will not correctly calculate the number of files to use in the test.
Fix:
If the result of ulimit -n cannot be treated as a number, modify it to use the predetermined default number of files (15,000) without forcing the calculation.