Skip to content

docs: Clarify when to open an issue for a PR #19974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 31, 2025
Merged

docs: Clarify when to open an issue for a PR #19974

merged 3 commits into from
Jul 31, 2025

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 28, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Clarified when it's expected that someone will open an issue before opening a pull request.

fixes #19922

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner July 28, 2025 14:45
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 28, 2025
Copy link

netlify bot commented Jul 28, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit cd00454
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/688a25a013f98c0008a9a33e
😎 Deploy Preview https://deploy-preview-19974--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jul 28, 2025
@Tanujkanti4441 Tanujkanti4441 added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 28, 2025
@Tanujkanti4441 Tanujkanti4441 moved this from Needs Triage to Implementing in Triage Jul 28, 2025
Copy link
Contributor

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification.

lumirlumir
lumirlumir previously approved these changes Jul 30, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Would like @Tanujkanti4441 to verify the changes before merging.

Co-authored-by: Amaresh  S M  <amareshsm13@gmail.com>
Copy link
Member

@amareshsm amareshsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving it open for second approval.

@nzakas nzakas dismissed Tanujkanti4441’s stale review July 31, 2025 16:00

Issue was fixed.

@nzakas nzakas merged commit fa20b9d into main Jul 31, 2025
31 checks passed
@nzakas nzakas deleted the issue19922 branch July 31, 2025 16:00
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Docs: Make issue requirement for PRs more clear
5 participants