build: use ESLint class to generate formatter examples
#19972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
commented
Jul 27, 2025
Comment on lines
+24
to
+25
| // Run from Makefile.js | ||
| "tools/generate-formatter-examples.js", |
There was a problem hiding this comment.
Knip didn't see this as used so I had to add it to ignore ,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Updates release process to use
ESLintclass instead of the oldCLIEngineclass when generating formatters docs.What changes did you make? (Give an overview)
Extracted generating formatters docs into a separate file to be able to run it synchronously and updated it to use the
ESLintclass. This ensures correctness of formatter examples in ESLint v9 (when using the default flat config mode) and is something we'd need to do sooner or later since theCLIEnginewill be removed in ESLint v10.Is there anything you'd like reviewers to focus on?