Skip to content

ci: pin jiti to version 2.4.2 #19964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025
Merged

ci: pin jiti to version 2.4.2 #19964

merged 1 commit into from
Jul 24, 2025

Conversation

fasttime
Copy link
Member

@fasttime fasttime commented Jul 24, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:

Pin a dev dependency.

refs unjs/jiti#388

What changes did you make? (Give an overview)

This PR temporarily pins the jiti dependency to version 2.4.2 to fix unit tests which are currently failing with jiti v2.5.0. E.g.:

https://github.com/eslint/eslint/actions/runs/16487028781/job/46615571667

Is there anything you'd like reviewers to focus on?

If a patch is released quickly, we could instead upgrade jiti to the newest version.

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 24, 2025
@eslint-github-bot eslint-github-bot bot added the build This change relates to ESLint's build process label Jul 24, 2025
Copy link

netlify bot commented Jul 24, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 872cba3
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6882079f5488180008e98b06

@fasttime fasttime marked this pull request as ready for review July 24, 2025 10:31
@fasttime fasttime requested a review from a team as a code owner July 24, 2025 10:31
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Merging this PR as there are CI errors caused by the newly released jiti v2.5.0.

@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 24, 2025
@lumirlumir lumirlumir merged commit 2ab1381 into main Jul 24, 2025
30 checks passed
@lumirlumir lumirlumir deleted the pin-jiti-2.4.2 branch July 24, 2025 12:03
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Jul 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion build This change relates to ESLint's build process
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants