Skip to content

feat: add eslint-plugin-regexp to eslint-config-eslint base config #19951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 14, 2025
Merged

feat: add eslint-plugin-regexp to eslint-config-eslint base config #19951

merged 6 commits into from
Aug 14, 2025

Conversation

Pixel998
Copy link
Contributor

@Pixel998 Pixel998 commented Jul 18, 2025 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

  • Added eslint-plugin-regexp as a dependency to eslint-config-eslint.
  • Extended the base config to include eslint-plugin-regexp's recommended rules.
  • Updated the export in base.js to spread the new regexp config.

Fixes #19945

Is there anything you'd like reviewers to focus on?

@Pixel998 Pixel998 requested a review from a team as a code owner July 18, 2025 07:42
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 18, 2025
@netlify Netlify
Copy link

netlify bot commented Jul 18, 2025 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 5cf1b2c
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6899c951220f410008b5b72b

@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Jul 18, 2025
@Pixel998 Pixel998 marked this pull request as draft July 18, 2025 08:02
@nzakas nzakas moved this from Needs Triage to Implementing in Triage Jul 28, 2025
@github-actions GitHub Actions
Copy link

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

@github-actions github-actions bot added the Stale label Jul 28, 2025
@github-actions github-actions bot added rule Relates to ESLint's core rules cli Relates to ESLint's command-line interface core Relates to ESLint's core APIs and features labels Aug 4, 2025
@Pixel998 Pixel998 marked this pull request as ready for review August 4, 2025 09:38
nzakas
nzakas previously approved these changes Aug 4, 2025
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

Would like another review before merging.

@nzakas nzakas moved this from Implementing to Second Review Needed in Triage Aug 4, 2025
@github-actions github-actions bot removed the Stale label Aug 4, 2025
@fasttime
Copy link
Member

fasttime commented Aug 5, 2025

Shall we release this feature as a breaking change? Otherwise other repos that use "eslint-config-eslint": "^11.0.0" could have their build suddenly broken. @eslint/eslint-team?

fasttime
fasttime reviewed Aug 5, 2025
View reviewed changes
@mdjermanovic
Copy link
Member

Shall we release this feature as a breaking change? Otherwise other repos that use "eslint-config-eslint": "^11.0.0" could have their build suddenly broken.

Yes, we should select major as RELEASE_TYPE when releasing eslint-config-eslint with these changes. But the tag should remain non-breaking, otherwise it would bump eslint's major version when releasing the eslint package.

mdjermanovic
mdjermanovic reviewed Aug 5, 2025
View reviewed changes
@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Aug 6, 2025
@fasttime fasttime mentioned this pull request Aug 6, 2025
Closed
@Pixel998 Pixel998 mentioned this pull request Aug 7, 2025
Merged
1 task
mdjermanovic
mdjermanovic reviewed Aug 10, 2025
View reviewed changes
mdjermanovic
mdjermanovic reviewed Aug 10, 2025
View reviewed changes
mdjermanovic
mdjermanovic reviewed Aug 11, 2025
View reviewed changes
mdjermanovic
mdjermanovic approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for @nzakas and @fasttime to re-review.

fasttime
fasttime approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@fasttime fasttime requested a review from nzakas August 11, 2025 18:55
@nzakas nzakas merged commit 43a5f9e into eslint:main Aug 14, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

@fasttime fasttime fasttime approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion cli Relates to ESLint's command-line interface contributor pool core Relates to ESLint's core APIs and features feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Triage
Status: Complete
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Request: adopt eslint-plugin-regexp
4 participants
@Pixel998 @fasttime @mdjermanovic @nzakas