fix: remove outdated types in ParserOptions.ecmaFeatures
#19944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ntnyq!, thanks for the Pull Request The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.
To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page. Read more about contributing to ESLint here |
✅ Deploy Preview for docs-eslint canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR removes the now-obsolete experimentalObjectRestSpread parser option from the ESLint type definitions and test suite to keep the API clean and up to date.
- Eliminates references to
experimentalObjectRestSpreadin existing tests. - Ensures the test suite reflects current supported
ParserOptions.
Comments suppressed due to low confidence (1)
tests/lib/types/types.test.ts:934
- Add a test to verify that supplying the now-removed parser option
experimentalObjectRestSpreadproduces the expected configuration error, ensuring this removal is correctly enforced.
{
ParserOptions.ecmaFeatures.experimentalObjectRestSpreadParserOptions.ecmaFeatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fix #19942
What changes did you make? (Give an overview)
This PR removes oudated types
ParserOptions.ecmaFeatures.experimentalObjectRestSpread.Is there anything you'd like reviewers to focus on?