Skip to content

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Adds docs/src/_data/further_reading_links.json to .prettierignore. This file is autogenerated by tools/fetch-docs-links.js, and updated on pre-commit if there are changes in rule docs files. As with any autogenerated files, this can cause formatting errors, as in #19941, so I think it would be best to exclude this file from Prettier formatting.

What changes did you make? (Give an overview)

  • Added docs/src/_data/further_reading_links.json to .prettierignore.
  • Updated tools/fetch-docs-links.js to keep the current formatting (2-space indentation) to avoid diff.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner July 15, 2025 10:00
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 15, 2025
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 46c0c8f
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/687626d167d98500081fc3f0
😎 Deploy Preview https://deploy-preview-19943--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jul 15, 2025
@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jul 15, 2025
@lumirlumir lumirlumir moved this from Needs Triage to Triaging in Triage Jul 15, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve felt the same way while working on the eslint repository—it looks good to me.

LGTM, Thanks!

@lumirlumir lumirlumir merged commit c565a53 into main Jul 15, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Triaging to Complete in Triage Jul 15, 2025
@lumirlumir lumirlumir deleted the fmt-ignore-further-links branch July 15, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion chore This change is not user-facing
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

2 participants