Skip to content

feat: support explicit resource management in one-var #19941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SwetaTanwar
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Related to #19792

Is there anything you'd like reviewers to focus on?

I have also improved the autofix output.

@SwetaTanwar SwetaTanwar requested a review from a team as a code owner July 15, 2025 06:11
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jul 15, 2025
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Jul 15, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Jul 15, 2025
Copy link

netlify bot commented Jul 15, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit d0fdd28
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/688772543799ec0008fb0c80
😎 Deploy Preview https://deploy-preview-19941--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mdjermanovic mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool labels Jul 19, 2025
@mdjermanovic mdjermanovic moved this from Needs Triage to Implementing in Triage Jul 19, 2025
@mdjermanovic
Copy link
Member

Going to close & reopen to re-run CI with the latest changes from the main branch.

@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jul 24, 2025
@mdjermanovic mdjermanovic reopened this Jul 24, 2025
@github-project-automation github-project-automation bot moved this from Complete to Evaluating in Triage Jul 24, 2025
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@mdjermanovic mdjermanovic moved this from Evaluating to Implementing in Triage Jul 28, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open for a second review.

@mdjermanovic mdjermanovic moved this from Implementing to Second Review Needed in Triage Jul 28, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@snitin315 snitin315 merged commit 90b050e into eslint:main Jul 28, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants