Skip to content

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Jun 10, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Original issue #19836.

What changes did you make? (Give an overview)

This PR fixes #19836 by correct the types and add type tests.

Is there anything you'd like reviewers to focus on?

@ntnyq ntnyq requested a review from a team as a code owner June 10, 2025 02:06
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jun 10, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 10, 2025
Copy link

netlify bot commented Jun 10, 2025

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 9b3036a
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6847f2cd1a8ec20008818b0f

@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 10, 2025
@fasttime fasttime moved this from Needs Triage to Implementing in Triage Jun 10, 2025
@fasttime fasttime added the types Related to TypeScript types label Jun 10, 2025
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime changed the title fix: fix lintOptions.filterCodeBlock types fix: fix LintOptions.filterCodeBlock types Jun 10, 2025
@fasttime fasttime merged commit 9bda4a9 into eslint:main Jun 10, 2025
30 checks passed
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Jun 10, 2025
@ntnyq ntnyq deleted the fix/filter-code-block-types branch June 25, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly types Related to TypeScript types
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: TypeScript and LintOptions interface: filterCodeBlock should not be typed as boolean
2 participants