You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjermanovic
changed the title
fix: handle negative column index in getIndexFromLoc and add tests
feat: throw error when column is negative in getIndexFromLocJun 9, 2025
I think it's fine for semver-minor. Using -1 now would cause a difficult-to-track-down error right now, so throwing a more useful one is definitely preferable.
I think this change is fine for a semver-minor release.
I agree. It's possible that this change could break some plugins, but since the current behavior for negative columns in locations was not intended or documented, this can be a fix.
acceptedThere is consensus among the team that this change meets the criteria for inclusionbugESLint is working incorrectlyfeatureThis change adds a new feature to ESLint
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Hello,
In this PR, I’ve fixed the handling of negative column indices in
getIndexFromLocand added corresponding tests.The JavaScript
SourceCodeclass is based on 0-indexed columns, so passing a negative column index should throw an error — but currently, it doesn’t.This could lead to unintended side effects or bugs, so I’ve addressed the issue accordingly.
Is there anything you'd like reviewers to focus on?