fix: allow separate default and named type imports #19899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
nzakas
previously approved these changes
Jun 30, 2025
fasttime
reviewed
Jul 1, 2025
There was a problem hiding this comment.
Should this case be considered valid as well?
{
code: `
import type A from "module";
export type { B } from "module";
`,
options: [{ includeExports: true }],
},There was a problem hiding this comment.
Yes I believe this should be valid.
28 tasks
|
We are going to release this fix with ESLint v9.30.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
This PR fixes a false positive in no-duplicate-imports rule where it incorrectly flagged separate default and named TypeScript type imports as duplicates. Since TypeScript syntax prohibits combining these into a single import statement, the rule should allow them to coexist without warnings.
What changes did you make? (Give an overview)
Fixes #19898
Is there anything you'd like reviewers to focus on?