feat: support explicit resource management in no-loop-func
#19895
+92
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Jun 29, 2025
snitin315
reviewed
Jun 30, 2025
docs/src/rules/no-loop-func.md
Outdated
Comment on lines
134
to
144
| for (var i=10; i; i--) { | ||
| using foo = getsomething(i); | ||
| var a = function() { return foo; }; // OK, all references are referring to block scoped variables in the loop. | ||
| a(); | ||
| } | ||
|
|
||
| for (var i=10; i; i--) { | ||
| await using foo = getsomething(i); | ||
| var a = function() { return foo; }; // OK, all references are referring to block scoped variables in the loop. | ||
| a(); | ||
| } |
There was a problem hiding this comment.
I think we will need to pass ECMA version 2026 in the code block to correctly open this in the playground.
There was a problem hiding this comment.
Doesn't it already work the same with the default latest?
There was a problem hiding this comment.
Yeah, that would work too. Anyway I also added 2026 as an option in eslint/eslint.org#737
snitin315
previously approved these changes
Jun 30, 2025
aladdin-add
reviewed
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Refs #19792, adds support for explicit resource management to the
no-loop-funcrule.What changes did you make? (Give an overview)
Updates the
no-loop-funcrule to not report on references tousingandawait usingvariables, because they are constant.Is there anything you'd like reviewers to focus on?
For
using/await usingvariables declared inside the loop body, it might make sense to warn when they are referenced from a function because they might be used after the loop, which would be after the disposal. However, I don't think this potential error is specific to loops, but to any blocks. Thus, I think the mentioned is out of scope for this rule, which targets cases where the referenced variables are reassigned.