Skip to content

feat: support explicit resource management in init-declarations #19893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2025

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Refs #19792, adds support for explicit resource management to the init-declarations rule.

What changes did you make? (Give an overview)

Updated the init-declarations rule to not report on initializing using and await using variables when the option is "never", because these variables must be initialized.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner June 29, 2025 16:14
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 29, 2025
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Jun 29, 2025
Copy link

netlify bot commented Jun 29, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit a28241b
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6861664eaae365000862e8b2
😎 Deploy Preview https://deploy-preview-19893--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the rule Relates to ESLint's core rules label Jun 29, 2025
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please get another review before merging, and wait until the current release concludes.​

@aladdin-add aladdin-add moved this from Needs Triage to Second Review Needed in Triage Jun 29, 2025
@aladdin-add aladdin-add added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 29, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Waiting for the patch-release window to close.

@snitin315 snitin315 moved this from Second Review Needed to Merge Candidates in Triage Jun 30, 2025
@fasttime fasttime merged commit 5848216 into main Jul 4, 2025
31 checks passed
@fasttime fasttime deleted the erm-initdeclarations branch July 4, 2025 04:15
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

4 participants