Skip to content

Conversation

ntnyq
Copy link
Contributor

@ntnyq ntnyq commented Jun 25, 2025

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes: #19820

What changes did you make? (Give an overview)

This PR updates all eslint-stylistic sub packages related links and plugin names.

Is there anything you'd like reviewers to focus on?

@Copilot Copilot AI review requested due to automatic review settings June 25, 2025 14:54
@ntnyq ntnyq requested a review from a team as a code owner June 25, 2025 14:54
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 25, 2025
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jun 25, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Jun 25, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates package references from the old @stylistic/js scope to the new @stylistic scope, adjusting plugin names, URLs, and rule links across tests, rule metadata, and documentation.

  • Update deprecated rule replacement references in tests.
  • Update plugin.name and plugin.url in all rule metadata to @stylistic/eslint-plugin and https://eslint.style.
  • Remove /js/ segment from all rule URLs in metadata and documentation.

Reviewed Changes

Copilot reviewed 78 out of 80 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/lib/eslint/eslint.js Updated replacedBy entries to new package names
lib/rules/*.js Updated plugin name, URL, and rule URLs
docs/src/use/formatters/index.md Updated example formatter output URLs
docs/src/_data/rules_meta.json Updated plugin info and rule URLs
docs/src/_data/rules.json Updated plugin info and rule URLs

Copy link

netlify bot commented Jun 25, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 72b8d3b
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/685cdfba7deca20008e9cc97
😎 Deploy Preview https://deploy-preview-19887--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 26, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this PR.

I’ve left a minor comment regarding the EOL in the autogenerated file.

To the team: I’ve manually checked all the links, and they’re working as expected. 👍

@lumirlumir lumirlumir moved this from Needs Triage to Implementing in Triage Jun 26, 2025
Copy link
Member

@lumirlumir lumirlumir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

Would like another review before merging.

@lumirlumir lumirlumir moved this from Implementing to Second Review Needed in Triage Jun 26, 2025
@snitin315 snitin315 changed the title fix: adopt eslint-stylistic sub packages related changes docs: adopt eslint-stylistic sub packages related changes Jun 26, 2025
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 26, 2025
Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Marking this change as docs because there is no direct user impact.

@snitin315 snitin315 removed the bug ESLint is working incorrectly label Jun 26, 2025
@snitin315 snitin315 merged commit 8662ed1 into eslint:main Jun 26, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Second Review Needed to Complete in Triage Jun 26, 2025
@ntnyq ntnyq deleted the fix/stylistic-url-changes branch July 22, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Rule Change: Adopt eslint-stylistic related url changes
3 participants