feat: support typescript types in accessor rules #19882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
|
Hi @DMartens, could you take a look at the CI failure? It’s currently throwing some errors related to Markdown files. |
JoshuaKGoldberg
previously approved these changes
Jul 8, 2025
… grouped-accessor-pairs
nzakas
previously approved these changes
Jul 10, 2025
There was a problem hiding this comment.
LGTM. Would like @JoshuaKGoldberg to review before merging.
|
@DMartens can you also update the corresponding rule types with the newly added options? |
JoshuaKGoldberg
previously approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What rule do you want to change?
accessor-pairs and grouped-accessor-pairs.
Fixes #19860.
What change do you want to make (place an "X" next to just one item)?
[x] Generate more warnings
[ ] Generate fewer warnings
[ ] Implement autofix
[ ] Implement suggestions
How will the change be implemented (place an "X" next to just one item)?
[x] A new option
[ ] A new default behavior
[ ] Other
Please provide some example code that this change will affect:
What does the rule currently do for this code?
Unchecked
What will the rule do after it's changed?
Also check getters and setters in interfaces and type literals
What changes did you make? (Give an overview)
enforceForTSTypesfor both rulesTSMethodSignaturein the utility functionsgetFunctionNameWithKindandgetStaticPropertyNameIs there anything you'd like reviewers to focus on?
No