Skip to content

Conversation

sethamus
Copy link
Contributor

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Added a new allowSeparateTypeImports option to the no-duplicate-imports rule that allows a type import alongside a value import from the same module in TypeScript files.

Closes #19834

Is there anything you'd like reviewers to focus on?

@sethamus sethamus requested a review from a team as a code owner June 18, 2025 00:19
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jun 18, 2025
@eslint-github-bot eslint-github-bot bot added the feature This change adds a new feature to ESLint label Jun 18, 2025
@github-actions github-actions bot added the rule Relates to ESLint's core rules label Jun 18, 2025
Copy link

netlify bot commented Jun 18, 2025

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 9fb7a4c
🔍 Latest deploy log https://app.netlify.com/projects/docs-eslint/deploys/6853641d6c11b10008903fd5
😎 Deploy Preview https://deploy-preview-19872--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lumirlumir lumirlumir added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 18, 2025
nzakas
nzakas previously approved these changes Jun 18, 2025
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Just a note on the docs to make things clearer.

Would like another review before merging.

@nzakas nzakas moved this from Needs Triage to Second Review Needed in Triage Jun 18, 2025
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving it open until tomorrow (2 days waiting period per our policies) to allow others to review it if they want before merging.

@mdjermanovic mdjermanovic moved this from Second Review Needed to Merge Candidates in Triage Jun 19, 2025
@mdjermanovic mdjermanovic changed the title feat: add allowSeparateTypeImports option to no-duplicate-imports feat: add allowSeparateTypeImports option to no-duplicate-imports Jun 20, 2025
@mdjermanovic mdjermanovic merged commit 4ab4482 into eslint:main Jun 20, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Merge Candidates to Complete in Triage Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion contributor pool feature This change adds a new feature to ESLint rule Relates to ESLint's core rules
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Rule Change: support TypeScript syntax in no-duplicate-imports
4 participants